Optionally filter email addresses #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first" This reverts commit a591789.
|
Thanks for making this backwards compatible. |
| @@ -45,6 +47,11 @@ def call | |||
| paragraphs = EmailReplyParser.read(text.dup).fragments.map do |fragment| | |||
| pieces = [escape_html(fragment.to_s.strip).gsub(/^\s*(>|>)/, '')] | |||
| if fragment.quoted? | |||
| if context[:hide_quoted_email_addresses] | |||
| pieces.map! do |piece| | |||
| piece.gsub!(EMAIL_REGEX, HIDDEN_EMAIL_PATTERN) | |||
There was a problem hiding this comment.
This is a bug 😢 gsub! can return nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common for email replies with quoted content to include email addresses in banners from quoted text. These email addresses may have been marked as private and by commenting via email, their email address is exposed. e.g.
Before
After
This adds a flag to the
EmailReplyFilterthat willgsubout things that look somewhat like email addresses (erring on the false positive side).Before
/cc @jch sorry I guess I forgot to hit submit before heading out for the weekend, tab was still open 😄